[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65414: save-some-buffers-functions are unexpectedly called when save
From: |
Joseph Turner |
Subject: |
bug#65414: save-some-buffers-functions are unexpectedly called when save-some-buffers pred is non-nil |
Date: |
Sun, 03 Sep 2023 10:52:39 -0700 |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> [ Arguably, it would be even better to arrange for `hyperdrive.el` to
> save its buffers "in the usual way", i.e. relying on
> `buffer-offer-save`, `save-buffer`, `buffer-save-without-query, ... ]
I was not aware of `buffer-offer-save`. Thank you for the suggestion!
Since we already rely on `save-buffer`, setting `buffer-offer-save` to t
is much simpler than adding to `save-some-buffers-functions`. It also
resolves the interference between Magit and hyperdrive.el.
However... I wonder what the intended purpose of
`save-some-buffers-functions` is if packages like `hyperdrive.el` are
intended to use `buffer-offer-save`?
Joseph
bug#65414: save-some-buffers-functions are unexpectedly called when save-some-buffers pred is non-nil, Juri Linkov, 2023/09/03