[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65605: [PATCH] Command and option to make Edmacro better for long se
From: |
Okamsn |
Subject: |
bug#65605: [PATCH] Command and option to make Edmacro better for long sequences |
Date: |
Sun, 03 Sep 2023 16:05:03 +0000 |
Eli Zaretskii wrote:
> If these commands are indeed important conveniences, they should be in
> the manual, I think.
I have described the new command and `edmacro-insert-key` in the manual.
> Defcustoms should have the :version tag.
I have given it as "30.1".
>
>> +(defun edmacro-set-macro-to-region-lines (beg end)
>> + "Set the Macro text to the lines of the region.
>
> We prefer to have the mandatory arguments mentioned in the first line
> of a function's doc string.
>
>> +If BEG is not at the beginning of a line, it is moved to the
>> +beginning of the line. If END is at the beginning of a line,
>> +that line is excluded. Otherwise, if END is not at the
>> +end of a line, it is moved to the end of the line."
>
> This describes the implementation, whereas this is a command, so the
> doc string should have users, not programmer's in mind. Try to
> describe BEG and END in user-level terms, for example:
>
> Macro text will start and the beginning of line containing buffer
> position BEG.
>
> Also, the doc string should tell how BEG and END are determined in
> interactive invocations.
>
I have changed it. How does it look now?
v3-0001-Make-using-Edmacro-better-for-long-sequences-of-k.patch
Description: Text Data
- bug#65605: [PATCH] Command and option to make Edmacro better for long sequences,
Okamsn <=