[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65604: [PATCH] Display the exit code if the last command failed in E
From: |
Davide Masserut |
Subject: |
bug#65604: [PATCH] Display the exit code if the last command failed in Eshell |
Date: |
Sat, 02 Sep 2023 20:54:38 +0200 |
Jim Porter <jporterbugs@gmail.com> writes:
2) It may require to update the regexp.
The prompt regexp is (thankfully) almost irrelevant in Emacs 30
now. It only matters for paragraph-movement commands, which we
could
probably just remap to the actual Eshell-specific commands to
navigate
forward and backward through the prompts. I should probably just
make
a patch for this and finally get rid of that regexp entirely.
I didn't know that, thanks.
In this case I would add a small delay before signaling that
something is running.
The delay isn't present in the current Eshell mode-line
implementation, and I don't think anyone's raised an issue about
that...
Sorry, I meant that if we decided to show a relative long message
like "Running" in the mode-line, then we should show it only when
it lasts for more than, let's say, 0.5s. This would prevent the
mode-line from moving to right for just a fraction of a second
when running fast commands like cd or ls.
... in any case, maybe the simplest way forward here is to put
the
(non-zero) exit status in the prompt like your original patch,
and
then separately, I can try to improve the customizability of the
prompt, as well as thinking about what to do with the mode-line.
I have updated the patch.
0001-Display-the-exit-code-if-the-last-command-failed-in-.patch
Description: Text Data