bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding


From: Stefan Kangas
Subject: bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding
Date: Fri, 1 Sep 2023 22:07:50 +0200

Version: 30.1

Stefan Kangas <stefankangas@gmail.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> +(defcustom checkdoc-lexical-binding-flag t
> >> +  "Non-nil means generate warnings if file is not using lexical binding.
> >> +See Info node `(elisp) Converting to Lexical Binding' for more."
> >> +  :type 'boolean
> >> +  :version "29.1")
> >
> > Should be "30.1", I guess?
>
> Yes, well spotted.
>
> >> +                 (checkdoc-create-error
> >> +                  "The first line should end with \"-*- lexical-binding: 
> >> t -*-\""
> >
> > Is this accurate?  IOW, does the lexical-binding cookie have to be the
> > last on the first line?
>
> You're right, it's not accurate.  I changed it to say:
>
>     The first line should contain "-*- lexical-binding: t -*-"
>
> > Otherwise, LGTM, thanks.
>
> Thanks.

Pushed to master as commit 7d60d1652fc.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]