[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-proje
From: |
Juri Linkov |
Subject: |
bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands |
Date: |
Thu, 31 Aug 2023 09:47:00 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
> I've tried the patch a little bit, some more impressions:
>
> - Unfortunately, using default-directory instead of the specialized
> variable which we added lately (project-current-directory-override)
> brings back the bug it was added for: https://debbugs.gnu.org/58784. The
> switch to a different design didn't fix the problem of the temporary
> binding for d-d in the buffer which is current when the command is
> executed. So adding the next-default-directory variable might not be the
> best idea after all. But the advice thingy can set a binding for any
> variable, including the *-override one.
I didn't test yet the cases from bug#58784. So this might require more changes.
> - I also managed to get into some transient state where some chars were
> doing one thing (their usual bindings), and some - invoked project
> commands instead, with no apparent method of quitting that state. Maybe
> I'll document it next time I see it.
It would be nice to have a reproducible test case.
But indeed chars in the project map invoke the project commands,
and all other chars fall back to local/global keybindings.
> - Using (project--keymap-prompt) for just a message call is cute, but
> I personally like the "guardrails": if I accidentally type a wrong char
> when choosing the command, I won't have to choose the other project
> again. This is debatable, but both modes of operation are probably worth
> keeping available (opinions welcome).
This is easy to do with something like in 'y-or-n-p-map'.
> - Either way, with method with the advice should be useful for other
> things, like project--other-place-command.
It's not recommended to use advice in the core packages,
maybe only for providing backward-compatibility with older versions.
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, sbaugh, 2023/08/10
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, sbaugh, 2023/08/10
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Spencer Baugh, 2023/08/23
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Juri Linkov, 2023/08/23
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Spencer Baugh, 2023/08/29
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Dmitry Gutov, 2023/08/29
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Spencer Baugh, 2023/08/29
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Dmitry Gutov, 2023/08/29
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Juri Linkov, 2023/08/30
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Dmitry Gutov, 2023/08/30
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands,
Juri Linkov <=
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Dmitry Gutov, 2023/08/31
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Juri Linkov, 2023/08/31
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Dmitry Gutov, 2023/08/31
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Dmitry Gutov, 2023/08/28
- bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands, Spencer Baugh, 2023/08/29