bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#65578: Eglot with mouse


From: Dmitry Gutov
Subject: bug#65578: Eglot with mouse
Date: Thu, 31 Aug 2023 03:27:29 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

Version: 30.1

On 30/08/2023 19:35, Juri Linkov wrote:
@@ -1637,7 +1637,9 @@ xref-find-definitions-at-mouse
-        (xref-find-definitions identifier)
+        (progn
+          (mouse-set-point event)
+          (xref-find-definitions identifier))
         (user-error "No identifier here"))))
The problem with this solution is that when it doesn't find
the identifier then it leaves point at the wrong place.
I'm not sure is a big problem, but we could save the original position and
restore it in case of error too:
Thanks.  I tend to agree with João that your initial version would be
sufficient to leave point at the position of right-clicking.

Then the same change is also needed in xref-find-references-at-mouse
with mouse-set-point before xref-find-references.

Very good, if you don't mind the side-effect too, I've pushed the fix for both functions to master. And closing.

BTW, this context-menu-mode is looking pretty nifty. It'd be nice to turn it on by default someday.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]