[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65604: [PATCH] Display the exit code if the last command failed in E
From: |
Eshel Yaron |
Subject: |
bug#65604: [PATCH] Display the exit code if the last command failed in Eshell |
Date: |
Wed, 30 Aug 2023 17:34:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hello Davide,
This looks interesting, a couple of thoughts:
> From 8b9f3870e00cdf920e803d92138a9bb0f3c3b645 Mon Sep 17 00:00:00 2001
> From: Davide Masserut <dm@mssdvd.com>
> Date: Wed, 30 Aug 2023 16:38:07 +0200
> Subject: [PATCH] Display the exit code if the last command failed in Eshell
>
[...]
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -370,6 +370,9 @@ to load the edited aliases.
> Running 'rgrep' in Eshell now uses the Emacs grep facility instead of
> calling external rgrep.
>
> +---
> +*** If the last command failed, its exit code is now displayed in the
> modeline.
> +
I suggest a small rephrase to avoid the passive voice:
"Eshell now displays the exit code of the last command in the mode line
when it's non-zero."
Also, shouldn't this also be mentioned in the manual?
> +(defun eshell-update-last-command-status (exit-code)
> + "Set `eshell-last-command-status' to EXIT-CODE and update
> `mode-line-process'."
> + (setq mode-line-process
> + (when (> exit-code 0)
> + (list
> + (let ((out-string (format ":[%s]" exit-code))
> + (msg (format "Last command exited with code %s"
> exit-code)))
> + (propertize out-string
> + 'help-echo msg
> + 'face 'compilation-mode-line-fail))))
> + eshell-last-command-status exit-code))
> +
You should be able to use an `:eval` mode line construct here instead of
resetting `mode-line-process` after each command this way. This would
allow other code to extend modify `mode-line-process` as well, without
having the modification undone after each command.
Best,
Eshel (no relation to Eshell)
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell, Davide Masserut, 2023/08/29
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell, Jim Porter, 2023/08/29
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell, Davide Masserut, 2023/08/30
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell, Davide Masserut, 2023/08/30
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell,
Eshel Yaron <=
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell, Eli Zaretskii, 2023/08/30
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell, Eli Zaretskii, 2023/08/30
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell, Davide Masserut, 2023/08/30
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell, Eli Zaretskii, 2023/08/30
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell, Davide Masserut, 2023/08/30
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell, Davide Masserut, 2023/08/30
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell, Eli Zaretskii, 2023/08/31
- bug#65604: [PATCH] Display the exit code if the last command failed in Eshell, Davide Masserut, 2023/08/31