bug#62216: Odd file corruption in clojure mode and emacs 30 HEAD

[Eli Zaretskii]

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: Jonathon McKitrick <jcm@SDF.ORG>,  Eli Zaretskii <eliz@gnu.org>,  Paul
>  Eggert <eggert@cs.ucla.edu>,  62216@debbugs.gnu.org
> Date: Wed, 30 Aug 2023 10:59:08 +0200
> 
> Po Lu <luangruo@yahoo.com> writes:
> 
> > Jonathon McKitrick <jcm@SDF.ORG> writes:
> >
> >> What's the best mechanism to log these values in emacs?
> >
> > In this case, printf.
> 
> When I add this assumption:
> 
> modified   src/fileio.c
> @@ -4805,8 +4805,11 @@ DEFUN ("insert-file-contents", Finsert_file_contents, 
> Sinsert_file_contents,
>  
>       /* 'try' is reserved in some compilers (Microsoft C).  */
>       ptrdiff_t trytry = min (gap_size, READ_BUF_SIZE);
> +     ptrdiff_t trytry_old = min (total - inserted, READ_BUF_SIZE);
>       if (!NILP (end))
>         trytry = min (trytry, total - inserted);
> +     if (trytry != trytry_old)
> +       abort ();
>  
>       if (!seekable && NILP (end))
>         {
> 
> and make bootstrap, temacs aborts.
> 
> Can someone tell if this assumption should hold?

You expect READ_BUF_SIZE to never be greater than gap_size?