[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65414: save-some-buffers-functions are unexpectedly called when save
From: |
Joseph Turner |
Subject: |
bug#65414: save-some-buffers-functions are unexpectedly called when save-some-buffers pred is non-nil |
Date: |
Sat, 26 Aug 2023 00:32:23 -0700 |
Eli Zaretskii <eliz@gnu.org> writes:
> So your problem is with Lisp programs that add functions to
> save-some-buffers-functions, but don't expect or don't want those
> functions to be called each time save-some-buffers is invoked?
Yes.
> I'm not sure how did those Lisp programs get the idea that
> save-some-buffers-functions will not be called always -- is it hinted
> by some documentation somewhere? If not, I'd say that those Lisp
> programs have a bug that needs to be fixed in those programs. Right?
I agree.
> In any case, not calling save-some-buffers-functions when PRED is
> non-nil is not something we can do, as that would be an incompatible
> behavior change. We could perhaps add PRED to the arguments with
> which save-some-buffers-functions are called, as an optional argument.
> Would that be satisfactory?
Yes, that would solve the interference between Magit and hyperdrive.el.
See patch.
Thank you!
Joseph
0001-Pass-PRED-to-each-of-save-some-buffers-functions.patch
Description: Text Data