bug#64046: 30.0.50; Quoting in customize choice tags

[Mauro Aranda]

Stephen Berman <stephen.berman@gmx.net> writes:

> Right after sending, I found an obvious problem: only one of the car or
> the cdr might be a string.  The following patch accounts for this:
>
> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
> index a70598bb6c9..891e98b6de5 100644
> --- a/lisp/wid-edit.el
> +++ b/lisp/wid-edit.el
> @@ -285,12 +285,18 @@ widget-choose
>    ;; Apply quote substitution to customize choice menu item text,
>    ;; whether it occurs in a widget buffer or in a popup menu.
>    (let ((items (mapc (lambda (x)
> -                       (when (consp x)
> -                         (dotimes (i (1- (length x)))
> -                           (when (stringp (nth i x))
> -                             (setcar (nthcdr i x)
> - (substitute-command-keys
> -                                      (car (nthcdr i x))))))))
> +                       (if (proper-list-p x)
> +                           (dotimes (i (1- (length x)))
> +                             (when (stringp (nth i x))
> +                               (setcar (nthcdr i x)
> + (substitute-command-keys
> +                                        (car (nthcdr i x))))))
> +                         ;; ITEMS has simple item definitions.
> +                         (when (consp x)
> +                           (when (stringp (car x))
> +                             (setcar x (substitute-command-keys (car 
x))))
> +                           (when (stringp (cdr x))
> +                             (setcdr x (substitute-command-keys (cdr 
x)))))))

Thinking about it, why do we need to call substitute-command-keys on the
VALUE part (i.e., the cdr of the cons cell), in case of simple item
definitions?

I re-read the bug report, but I didn't find any reference to why that is
a need.  Did I miss something?

(I'll be going on a trip for the weekend, so apologies if I can't
see your response soon enough)