[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62812: [PATCH] Re: bug#62812: 29.0.60; Persistent article cache not
From: |
Eli Zaretskii |
Subject: |
bug#62812: [PATCH] Re: bug#62812: 29.0.60; Persistent article cache not working properly |
Date: |
Thu, 24 Aug 2023 08:50:06 +0300 |
> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Cc: James Thomas <jimjoe@gmx.net>, Andrew G Cohen <cohen@andy.bu.edu>,
> 62812@debbugs.gnu.org
> Date: Wed, 23 Aug 2023 09:47:17 -0700
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: James Thomas <jimjoe@gmx.net>
> >> Date: Wed, 23 Aug 2023 19:07:51 +0530
> >>
> >> James Thomas wrote:
> >>
> >> > Turned out to be a trivial fix:
> >> >
> >> > diff --git a/lisp/gnus/nnmail.el b/lisp/gnus/nnmail.el
> >> > index e8f157392d4..904b564409a 100644
> >> > --- a/lisp/gnus/nnmail.el
> >> > +++ b/lisp/gnus/nnmail.el
> >> > @@ -667,7 +667,9 @@ nnmail-parse-active
> >> > (cond ((symbolp group)
> >> > (symbol-name group))
> >> > ((numberp group)
> >> > - (number-to-string group))))
> >> > + (number-to-string group))
> >> > + ((stringp group)
> >> > + group)))
> >> > (if (and (numberp (setq max (read buffer)))
> >> > (numberp (setq min (read buffer))))
> >> > (push (list group (cons min max))
> >>
> >> And it'll merely make it the same as this already-existing code
> >> elsewhere:
> >>
> >> diff -u --label ./lisp/gnus/gnus-start.el --label \#\<buffer\
> >> gnus-start.el\> ./lisp/gnus/gnus-start.el /tmp/buffer-content-IYvzRp
> >> --- ./lisp/gnus/gnus-start.el
> >> +++ #<buffer gnus-start.el>
> >> @@ -2149,8 +2149,6 @@
> >> (number-to-string group))
> >> ((symbolp group)
> >> (symbol-name group))
> >> - ((stringp group)
> >> - group)))))
> >> (numberp (setq max (read cur)))
> >> (numberp (setq min (read cur)))
> >> (null (progn
> >>
> >> --
> >
> > Eric, Andrew: any comments?
>
> Yes! This looks like a correct fix to me.
OK, but now I'm confused regarding which change(s) to install. This
discussion includes 3 changes, so which ones are proposed and
approved? James, would you please post a single consolidated patch
you think should be installed, with the appropriate commit log
message?
Thanks.