bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#64531: [PATCH v2] Add new command vc-dir-copy-filename-as-kill


From: Dmitry Gutov
Subject: bug#64531: [PATCH v2] Add new command vc-dir-copy-filename-as-kill
Date: Sun, 20 Aug 2023 13:26:02 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

On 20/08/2023 09:26, Eli Zaretskii wrote:
Date: Sun, 20 Aug 2023 02:33:59 +0300
Cc: 64531@debbugs.gnu.org
From: Dmitry Gutov <dgutov@yandex.ru>

The difference from dired-copy-filename-as-kill in handing of the prefix
argument looks unfortunate (as a principle), but I'd rather leave it for
you to judge. Perhaps changing the latter command's interface would be a
better choice; I'm not sure why it works that way.

What difference is that?  I must be missing something, since it sounds
like both commands use the argument to select absolute or relative
file names?

One of them mandates M-0 for that effect.

Implementation difference: instead of going through (format "%S"), this
one uses shell-quote-argument. Is that good enough for Windows systems?

It depends on how the result will be used.  But maybe we should do the
same as dired-copy-filename-as-kill, just for consistency of the UX?

Maybe.

I imagine it might be used in a shell, but indeed there are different options.

And one more difference which we might want to see fixed:

    (When there's a single file, no quoting is done.)

It seems like, at least, in some usage scenarios users would prefer to
have copied filename not quoted. E.g. for subsequent use with find-file
or... something similar. I don't really use this command all that much,
so maybe I'm mistaken here, though.

There will always be cases when quoting gets in the way, but hopefully
they are rare.  The important thing, IMO, is that quoting is useful
for many/most uses of the file names in VC commands.  Is it?

When using 'M-!'? Maybe. I think consistency between 'w' commands is somewhat important, though.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]