bug#65277: 29.1.50; emacsclient Dired: frame is closed/killed when opening another dir

[brickviking]

Yes, sorry about that. I missed an error when retrieving the patch from the email. This altered the patch so that one of the hunks didn't succeed (I missed an initial space off the bottom comment line of the patch).

I've corrected the patch on my end and done some more testing. Configured, patched, compiled and installed.

---- text ----
    shell1$ emacs -Q

    M-x server-mode
Starts as per normal, window stays up.

    shell2$ emacsclient -t GNUmakefile

This opens a text window with the contents of GNUmakefile. 

    C-x C-v INSTALL
INSTALL now opens in the buffer, and I can use it as normal. Trying to
shut the client down with C-x # results in the message
    "No server buffers remain to edit"

(not client buffers as you said will happen) so I just did C-x 5 0 to terminate the client.

---- GUI ----
Starting up a GUI client with emacsclient -c GNUmakefile shows that file in the window. 

    C-x C-v INSTALL

then shows the install file, and crucially, the terminal doesn't return to the shell prompt. I still see "Waiting for Emacs..." in the terminal until I exit the client window.

At least on my end, this appears to work as advertised.

Regards, brickviking

On Sat, 19 Aug 2023 at 00:10, Eli Zaretskii <eliz@gnu.org> wrote:

> From: brickviking <brickviking@gmail.com>
> Date: Fri, 18 Aug 2023 20:22:24 +1200
>
> Okay. Patch applied, compiled, installed, executed emacs from shell1.
> ----- text -----
>     shell1$ emacs -Q
> I started server: M-x server-start. Window stays up.
>
>     shell2$ emacsclient -t GNUmakefile
> It then opens with contents of GNUmakefile.
>
> I then go C-x C-v INSTALL, hit enter, and get returned back to the prompt.

That's not what I see here.  I see INSTALL, and I don't get back to
the prompt.  If you indeed compiled the latest patch, this is strange.

> The behaviour differs for the GUI client in that I open emacsclient -C GNUmakefile after starting the
> server, and GNUmakefile shows in the window.
> When I go C-x C-v INSTALL <RET> the emacsclient window closes (and returns me to a prompt),
> and the INSTALL appears in a buffer in the original server window.

That's also not what I see.

I suspect you used one of the previous patches, or maybe didn't
install the patch correctly.

Thanks.