bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function

[Alan Mackenzie]

Hello, Stefan.

On Sat, Aug 12, 2023 at 14:28:44 -0400, Stefan Monnier wrote:
> >> I couldn't really think of any alternative for IT ("it" being to
> >> implement `cl-labels` and `cl-flet`).  FWIW, the pre-cl-lib code
> >> did IT differently by duplicating `macroexp--expand-all` wholesale
> >> and then tweaking its handling of `function` in an ad-hoc way.

> > Your reply doesn't address my question.  It is not clear to me what
> > the IT in your previous paragraph is.  You may or may not have
> > thought of some alternative for IT, and previous code may have done
> > IT differently, but that doesn't help me understand what IT is.
> > What was the difficulty in cl-labels and cl-flet for which IT and
> > cl--labels-convert was the solution?

> > The code is substituting (function F) with a non-eq (function F).
> > You're saying this has some effect in macroexp--expand-all.  I can't see
> > that, yet.  All I see is FORM, (function F), being substituted by a
> > different (function F) in L327 of macroexp.el.  Then there are the pcase
> > arms for (function (lambda ....)) and for (function ....).  Are either
> > of these pcase arms affected by the "expansion" of FORM?  If so, how?
> > Or am I looking at the wrong place entirely?

> `cl-flet` needs to replace (function LOCALFUN) with LOCALVAR within the
> body of the let, for those LOCALFUNs defined in the `cl-flet`.
> That's easy to do with a macro.

> But it also should leave all other uses of `function` untouched.
> That's the part that does not map well to macros since macros are
> repeatedly expanded until they return something that's not a macro call.

Thanks, that's useful information.  But it doesn't address my questions
in the slightest.  This is the third time I'm asking you for help.  I
thought it would be quicker than figuring everything out on my own.  You
wrote the code, I think.

I don't understand how cl--labels-convert works, down at the car and cdr
level.  I'm asking you to help me, but I'm not sure how sensible it is
to carry on asking repeatedly.  I've replaced two paragraphs you snipped
from your last reply.

Would you please answer these specific questions, now, to help me
understand this difficult mechanism.  Thanks!

> >> It's not a function but a special operator, which is thus handled in
> >> a hard-coded way by `macroexp--expand-all`.
> > Is it the case that this hard-coded handling for function is prevented
> > by the macro "expansion" of (function F)?

> Yes, we first expand the macros and then try to handle the result
> which should be one of the hard-coded cases (or is otherwise assumed to
> be a function call).

Are you talking about the code in macroexp--expand-all, here?  By
"macros", do you mean cl-flet and cl-labels here (as opposed to
function)?  What do you mean by "hard-coded cases"?  Do you mean the
pcase arms in macroexp--expand-all?  If so, which ones?

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).