[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65183: 29.1; Child frame moving and resizing problems
From: |
martin rudalics |
Subject: |
bug#65183: 29.1; Child frame moving and resizing problems |
Date: |
Sun, 13 Aug 2023 09:21:02 +0200 |
> But there is one thing that I don't know what the best solution is: how to
> reuse the code
> in the function `adjust_frame_size' (defined in src/frame.c, used by
> `set-frame-size')?
> I want to add two arguments: `new_x' and `new_y'. When `new_x' and `new_y'
> are the
> same with the current frame position,
... with GNOME/mutter it's hard to tell but that shouldn't bother us
here ...
> execute the original branch
> (`set_window_size_hook'
> or `resize_frame_window'); otherwise, call a move and resize function.
> But I have to rename this function to `adjust_frame_position_and_size'. For
> compatibility,
Alternatively you could put new_x and new_y together with an identifier
(say 'size_and_position') into PARAMETER and extract them before running
the hook. INHIBIT would be 1 anyway, so frame_inhibit_resize is of no
concern here.
> I will also create a wrapper function called `adjust_frame_size', in which
> `adjust_frame_position_and_size' is called with the current frame position
> as the last two args
This is the crucial point - rewriting all those adjust_frame_size calls
would be a great pain.
> so that the frame will be only resized but not moved.
> Do you think this is an appropriate solution?
I think so, yes.
Before coding other backends of set_window_size_hook make sure that the
code gives the desired results on your own system to avoid writing them
without any gain.
martin
- bug#65183: 29.1; Child frame moving and resizing problems, (continued)
- bug#65183: 29.1; Child frame moving and resizing problems, Eli Zaretskii, 2023/08/10
- bug#65183: 29.1; Child frame moving and resizing problems, martin rudalics, 2023/08/11
- bug#65183: 29.1; Child frame moving and resizing problems, 陈宇迪, 2023/08/11
- bug#65183: 29.1; Child frame moving and resizing problems, martin rudalics, 2023/08/11
- bug#65183: 29.1; Child frame moving and resizing problems, 陈宇迪, 2023/08/11
- bug#65183: 29.1; Child frame moving and resizing problems, Po Lu, 2023/08/11
- bug#65183: 29.1; Child frame moving and resizing problems, martin rudalics, 2023/08/12
- bug#65183: 29.1; Child frame moving and resizing problems, martin rudalics, 2023/08/12
- bug#65183: 29.1; Child frame moving and resizing problems, 陈宇迪, 2023/08/12
- bug#65183: 29.1; Child frame moving and resizing problems,
martin rudalics <=
- bug#65183: 29.1; Child frame moving and resizing problems, 陈宇迪, 2023/08/13
- bug#65183: 29.1; Child frame moving and resizing problems, martin rudalics, 2023/08/15