[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65113: Emacs-29 and master csharp-mode with broken treesit
From: |
J M |
Subject: |
bug#65113: Emacs-29 and master csharp-mode with broken treesit |
Date: |
Thu, 10 Aug 2023 23:42:22 +0100 |
Hi Eli
See attached the requested backward-compatible change.
0001-Update-csharp-treesit-support-due-to-upstream-change.patch
Description: Binary data
> On 10 Aug 2023, at 10:05, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> Date: Mon, 07 Aug 2023 07:46:05 +0200
>> From: Theodor Thornhill <theo@thornhill.no>
>> CC: 65113@debbugs.gnu.org
>
> Ping! Can we please have a patch that is backward-compatible?
>
>> On 6 August 2023 17:36:47 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>>>> From: J M <jean@tbm.email>
>>>> Date: Sun, 6 Aug 2023 16:03:45 +0100
>>>>
>>>> Treesit is broken for csharp-mode in the latest version in master and
>>>> emacs-29 and therefore does not provide syntax highlighting. 
>>>>
>>>> The latest grammar repository
>>>> (https://github.com/tree-sitter/tree-sitter-c-sharp) has removed the
>>>> keyword void_keyword.
>>>>
>>>> Please see attached the patch to resolve the issue.
>>>
>>> Thanks, but your patch will not work with the older version of the
>>> grammar library, right? Is it possible to make a patch that will work
>>> with both? Wed cannot rely on users having the latest grammar
>>> versions, so a backward-compatible change is much more preferable.
>>
>> We've had some similar patches lately that you can use for inspiration.
>>
>> Thanks,
>> Theo
>>