bug#65175: 30.0.50; get-device-terminal signals error when using isearch in keyboard macro

[Po Lu]

Richard Copley <rcopley@gmail.com> writes:

> When isearch is invoked from a keyboard macro, an error is signalled.
>
> Recipe:
>  C-x (      ;; kmacro-start-macro
>  C-s      ;; isearch-forward
>  e      ;; isearch-printing-char
>  <return> ;; isearch-exit
>  C-x )      ;; kmacro-end-macro
>  C-x e      ;; kmacro-end-and-call-macro
>
> Backtrace:
> Lisp error: (error "Invalid argument macro in ‘get-device-terminal’")
>   error("Invalid argument %s in `get-device-terminal'" macro)
>   get-device-terminal(macro)
>   frames-on-display-list(macro)
>   framep-on-display(macro)
>   device-class(macro nil)
>   isearch-mode(t t nil nil)
>   isearch-forward-regexp(nil 1)
>   funcall-interactively(isearch-forward-regexp nil 1)
>   command-execute(isearch-forward-regexp)
>   kmacro-call-macro(1 nil)
>   kmacro-end-and-call-macro(1)
>   funcall-interactively(kmacro-end-and-call-macro 1)
>   command-execute(kmacro-end-and-call-macro)
>
>>From the docstring for ‘last-event-frame’: "If the last event came
> from a keyboard macro, this is set to ‘macro’." When the value is
> ‘macro’, it should not be passed to ‘device-class’.
>
> Introduced in commit:
>   e3b50ec8ec1b8d1246aa2496f3fe8bf98d354545
>   Author:     Po Lu <luangruo@yahoo.com>
>   AuthorDate: Sat Jan 28 14:29:51 2023 +0800
>
>   Update Android port

I think this should be fixed now.  Please test and ack, thanks.