[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents
From: |
Po Lu |
Subject: |
bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported |
Date: |
Wed, 09 Aug 2023 16:15:53 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Mattias Engdegård <mattias.engdegard@gmail.com> writes:
> The current (4767f5eaee) code on emacs-29 fails fileio-tests with:
>
> Test fileio-tests--non-regular-insert condition:
> (ert-test-failed
> ((should-error
> (insert-file-contents "/dev/urandom" nil 5 10))
> :form
> (insert-file-contents "/dev/urandom" nil 5 10)
> :value
> ("/dev/urandom" 5)
> :fail-reason "did not signal an error"))
Right, but that's a problem with the test: /dev/urandom is seekable
under the Linux kernel. I fixed this on master by checking for a
regular file instead of a seekable file when verifying BEG, but that's
too extensive a change for Emacs 29.
- bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported, (continued)
- bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported, Paul Eggert, 2023/08/09
- bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported, Eli Zaretskii, 2023/08/10
- bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported, Paul Eggert, 2023/08/10
- bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported, Eli Zaretskii, 2023/08/10
- bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported, Paul Eggert, 2023/08/11
- bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported, Eli Zaretskii, 2023/08/11
- bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported, Paul Eggert, 2023/08/11
- bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported, Eli Zaretskii, 2023/08/12
- bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported, Po Lu, 2023/08/12
bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported, Mattias Engdegård, 2023/08/09
- bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported,
Po Lu <=