bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#65030: 30.0.50; Check keyword args of make-process


From: Mattias Engdegård
Subject: bug#65030: 30.0.50; Check keyword args of make-process
Date: Sun, 6 Aug 2023 10:49:59 +0200

6 aug. 2023 kl. 06.58 skrev Eli Zaretskii <eliz@gnu.org>:

> Any specific comments to the proposed patch?  Or do you think it is
> good to go?

Good to go as far as I'm concerned. It will be genuinely useful, and I see no 
serious problems with the implementation.

It can be extended but that would not prevent it from being committed as-is. 
For example, something that detects omitted values in the middle, not just the 
end, of the argument list. (The feasibility of this depends on the likelihood 
of argument values being keywords themselves.)

The main objection is that `make-process`, due to its design, is often called 
indirectly using `apply` which would not trigger the application of this 
compiler macro, so perhaps we should improve the error handling of 
Fmake_process instead.







reply via email to

[Prev in Thread] Current Thread [Next in Thread]