bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking i


From: Eli Zaretskii
Subject: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired
Date: Sat, 05 Aug 2023 16:12:21 +0300

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 65052@debbugs.gnu.org
> Date: Sat, 05 Aug 2023 14:58:16 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Manuel Giraud <manuel@ledu-giraud.fr>
> >> Cc: 65052@debbugs.gnu.org
> >> Date: Sat, 05 Aug 2023 11:27:08 +0200
> >> 
> >> >> Hmm... okay, but I wonder why not call image-dired-track-original-file
> >> >> and image-dired--update-header-line directly from each of these new
> >> >> commands, after scroll-up/down, instead of implementing this as a
> >> >> macro (which calls another macro).  That would have been much simpler
> >> >> and easier to follow.  Or is there something I'm missing here?
> >> >
> >> > Yes it would be much simpler.  I was trying to "stay in line" with the
> >> > current code.  I could try to add the scroll-up/down feature and maybe,
> >> > in a later patch, try to remove thoses macros.  WDYT?
> >> 
> >> Here.  The code is more obvious this way and I think we should do the
> >> same for other movements.
> >
> > Yes, thanks.
> 
> Maybe I should do that into another bug report?

It's up to you.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]