bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-


From: Wilhelm Kirschbaum
Subject: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode
Date: Mon, 31 Jul 2023 09:22:40 +0200
User-agent: mu4e 1.9.3; emacs 30.0.50


Dmitry Gutov <dmitry@gutov.dev> writes:

On 30/07/2023 10:53, Wilhelm Kirschbaum wrote:
With the new patch, it will continue highlight the sigil name ("r") in
regexps, but no in other sigil types (s/c/w).

Incorrect, just below there is a:
           (sigil) @font-lock-string-face)
without a match, so they will be highlighted, but just more
generically
as we don't know which sigils the user might have assigned.

Why not add elixir-ts-font-sigil-name-face in that matcher as well?

I think it is worth keeping the default/fallback case as simple as
possible and if there is a need to add special font to more specific
cases.  In this case it would have no impact if the font is not
customized.  Is there a reason you believe it would be better?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]