[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64799: [PATCH] Add 'project-prompt-key' face
From: |
Philip Kaludercic |
Subject: |
bug#64799: [PATCH] Add 'project-prompt-key' face |
Date: |
Sun, 23 Jul 2023 13:59:41 +0000 |
Protesilaos Stavrou <info@protesilaos.com> writes:
>> From: Philip Kaludercic <philipk@posteo.net>
>> Date: Sun, 23 Jul 2023 13:41:43 +0000
>>
>> Protesilaos Stavrou <info@protesilaos.com> writes:
>>
>>> Dear maintainers,
>>>
>>> I noticed that the project switching dispatch menu hardcodes its face to
>>> 'bold'. Adding a new face here allows themes/users to customise that
>>> style (e.g. to inherit the 'help-key-binding' face).
>>
>> Does this even need a separate face, or shouldn't `help-key-binding' be
>> reused directly?
>
> That would be my choice, though also with the removal of the square
> brackets around it. The proposed patch is for backward-compatibility.
Backwards-compatible to what? Can someone depend on this specific
behaviour? I think it would be better to replace the current code with
what you are suggesting, as a step towards ensuring a more consistent
user interface.
- bug#64799: [PATCH] Add 'project-prompt-key' face, Protesilaos Stavrou, 2023/07/23
- bug#64799: [PATCH] Add 'project-prompt-key' face, Philip Kaludercic, 2023/07/23
- bug#64799: [PATCH] Add 'project-prompt-key' face, Protesilaos Stavrou, 2023/07/23
- bug#64799: [PATCH] Add 'project-prompt-key' face,
Philip Kaludercic <=
- bug#64799: [PATCH] Add 'project-prompt-key' face, Protesilaos Stavrou, 2023/07/24
- bug#64799: [PATCH] Add 'project-prompt-key' face, Dmitry Gutov, 2023/07/24
- bug#64799: [PATCH] Add 'project-prompt-key' face, Philip Kaludercic, 2023/07/25
- bug#64799: [PATCH] Add 'project-prompt-key' face, Dmitry Gutov, 2023/07/25
- bug#64799: [PATCH] Add 'project-prompt-key' face, Protesilaos Stavrou, 2023/07/26
- bug#64799: [PATCH] Add 'project-prompt-key' face, Eli Zaretskii, 2023/07/26
- bug#64799: [PATCH] Add 'project-prompt-key' face, Dmitry Gutov, 2023/07/26
- bug#64799: [PATCH] Add 'project-prompt-key' face, Eli Zaretskii, 2023/07/27
- bug#64799: [PATCH] Add 'project-prompt-key' face, Dmitry Gutov, 2023/07/27
- bug#64799: [PATCH] Add 'project-prompt-key' face, Eli Zaretskii, 2023/07/28