[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60712: 28.2; customize-set-variable won't let you change the type of
From: |
Eli Zaretskii |
Subject: |
bug#60712: 28.2; customize-set-variable won't let you change the type of a choice |
Date: |
Sat, 22 Jul 2023 15:59:15 +0300 |
> Cc: Omar Antolín Camarena <omar.antolin@gmail.com>
> Date: Sun, 16 Jul 2023 10:27:39 -0300
> From: Mauro Aranda <maurooaranda@gmail.com>
>
> Mauro Aranda <maurooaranda@gmail.com> writes:
>
> > We have this condition in widget-choice-prompt-value:
> > ((and (= (length args) 2)
> > (memq old args))
> > (if (eq old (nth 0 args))
> > (nth 1 args)
> > (nth 0 args)))
> >
> > ARGS holds the choices available in the choice widget and OLD has
> > the choice that matches the current value of the choice widget, before
> > the user enters a new one. This branch has been in the code since like
> > forever, but I can't explain why it's good to have it.
>
> So, we should respect the value of widget-choice-toggle also when
> prompting, of course. I attach a patch to fix it.
Thanks, installed on the master branch, and closing the bug.