[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64347: 30.0.50; Some customize faces shown as edited with -Q
From: |
Mauro Aranda |
Subject: |
bug#64347: 30.0.50; Some customize faces shown as edited with -Q |
Date: |
Sat, 15 Jul 2023 17:11:21 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 |
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Fri, 30 Jun 2023 11:05:33 -0300
>> From: Mauro Aranda <maurooaranda@gmail.com>
>> Cc: Stephen Berman <stephen.berman@gmx.net>, Eli Zaretskii
<eliz@gnu.org>
>>
>> To sum it up, I think there are bugs in custom-face-attributes. One is
>> most surely a typo, and the other ones are oversights in the filters for
>> the :underline and :box properties. Fixing those, we are left with one
>> bug, I think, that will be reproducible with Emacs -Q and evaluating:
>>
>> (defface test
>> '((((supports :underline (:style wave)))
>> :underline (:color "Red1" :style wave))
>> (t
>> :inherit warning))
>> "...")
>>
>> (defface test-2
>> '((((supports :underline (:style wave)))
>> :underline (:style wave :color "Red1"))
>> (t
>> :inherit warning))
>> "...")
>>
>> M-x customize-face RET test
>> will show STANDARD state
>>
>> while
>> M-x customize-face RET test-2
>> will show EDITED state
>
> Thanks.
>
> Can you show a patch for the two bugs you've succeeded to identify?
>
> Did you make any progress with the one bug that's left after the other
> two are fixed?
Here's a patch for the typo.
Concerning the other bugs I discovered, I think that while the filters
could be tweaked, a better fix would be to teach face-spec-match-p
about matching plists correctly and not just by equality.
0001-Fix-typo-in-pre-filter-for-underline-property.patch
Description: Text Data
- bug#64347: 30.0.50; Some customize faces shown as edited with -Q, Eli Zaretskii, 2023/07/08
- bug#64347: 30.0.50; Some customize faces shown as edited with -Q, Mauro Aranda, 2023/07/08
- bug#64347: 30.0.50; Some customize faces shown as edited with -Q, Eli Zaretskii, 2023/07/09
- bug#64347: 30.0.50; Some customize faces shown as edited with -Q, Mauro Aranda, 2023/07/09
- bug#64347: 30.0.50; Some customize faces shown as edited with -Q, Eli Zaretskii, 2023/07/09
- bug#64347: 30.0.50; Some customize faces shown as edited with -Q, Mauro Aranda, 2023/07/09
- bug#64347: 30.0.50; Some customize faces shown as edited with -Q, Eli Zaretskii, 2023/07/10
- bug#64347: 30.0.50; Some customize faces shown as edited with -Q, Mauro Aranda, 2023/07/10
- bug#64347: 30.0.50; Some customize faces shown as edited with -Q, Mauro Aranda, 2023/07/15
- bug#64347: 30.0.50; Some customize faces shown as edited with -Q, Eli Zaretskii, 2023/07/20
bug#64347: 30.0.50; Some customize faces shown as edited with -Q,
Mauro Aranda <=