[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64543: [PATCH] package-report-bug: don't fail on custom groups defin
From: |
sbaugh |
Subject: |
bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval |
Date: |
Sat, 15 Jul 2023 17:45:12 +0000 (UTC) |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Philip Kaludercic <philipk@posteo.net> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> Date: Sat, 15 Jul 2023 09:12:48 +0000 (UTC)
>>> From: Spencer Baugh <sbaugh@catern.com>
>>> Cc: Philip Kaludercic <philipk@posteo.net>, sbaugh@janestreet.com,
>>> 64543@debbugs.gnu.org
>>>
>>> On Jul 15, 2023 04:57, Eli Zaretskii <eliz@gnu.org> wrote:
>>>
>>> > >> Previously we just assumed that the car of an element of
>>> > >> custom-current-group-alist was a filename. But actually it
>>> > >> can be nil
>>> > >> if a custom group was defined by just evaling Lisp.
>>> > >
>>> > > Where is this behaviour documented? I couldn't reproduce it with a
>>> > > simple experiment.
>>> >
>>> > To reproduce:
>>> > M-: (defgroup mygroup nil "my group") RET
>>> >
>>> > The patch would ensure that if groups like these are defined (which
>>> > might happen by mistake), then `package-report-bug' will remain robust
>>> > and not fail due to a unrelated issue.
>>>
>>> Is this case important enough to make this change so late in the
>>> pretest? Spencer, how did you bump into this situation in Real Life?
>>>
>>> I evaled a buffer containing a defgroup with C-c C-e (or maybe just
>>> a region?)
>>
>> Why did you do that?
>
> Evaluating an entire buffer with C-c C-e is not unreasonable, but it
> will not bind `load-file-name', which `load-file' would have done, but
> there is no binding for that.
Maybe we should add a binding for load-file? Or maybe C-c C-e should
bind load-file-name if the region is not active?
Btw, just curious: how do others test modifications they make to Lisp
files? I usually make a couple changes to several functions or
variables and then reloading the whole file is easier than going defun
by defun.
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, (continued)
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, Spencer Baugh, 2023/07/12
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, Philip Kaludercic, 2023/07/14
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, Eli Zaretskii, 2023/07/15
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, Philip Kaludercic, 2023/07/15
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, Eli Zaretskii, 2023/07/15
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, Spencer Baugh, 2023/07/15
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, Eli Zaretskii, 2023/07/15
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, Philip Kaludercic, 2023/07/15
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, Eli Zaretskii, 2023/07/15
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, Philip Kaludercic, 2023/07/15
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval,
sbaugh <=
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, Philip Kaludercic, 2023/07/16
- bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval, Eli Zaretskii, 2023/07/13