[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent
From: |
sbaugh |
Subject: |
bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections |
Date: |
Sat, 15 Jul 2023 17:38:01 +0000 (UTC) |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Eli Zaretskii <eliz@gnu.org> writes:
>> Resent-To: bug-gnu-emacs@gnu.org
>> Cc: sbaugh@catern.com, 64423-done@debbugs.gnu.org, sbaugh@janestreet.com
>> Date: Sat, 15 Jul 2023 12:01:31 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>>
>> > From: Po Lu <luangruo@yahoo.com>
>> > Cc: sbaugh@catern.com, sbaugh@janestreet.com, 64423@debbugs.gnu.org
>> > Date: Sat, 15 Jul 2023 16:33:13 +0800
>> >
>> > Eli Zaretskii <eliz@gnu.org> writes:
>> >
>> > >> From: sbaugh@catern.com
>> > >> Date: Thu, 13 Jul 2023 22:39:10 +0000 (UTC)
>> > >> Cc: luangruo@yahoo.com, sbaugh@janestreet.com, 64423@debbugs.gnu.org
>> > >>
>> > >> > Fine by me, but please add a comment there explaining why we do
>> > >> > that
>> > >> > on X.
>> > >> >
>> > >> > Thanks.
>> > >>
>> > >> OK, comment added, here's the patch.
>> > >
>> > > Thanks, LGTM. Po Lu, any objections?
>> >
>> > None here. Please go ahead and install it.
>>
>> Thanks, installed on the emacs-29 branch, and closing the bug.
>
> This causes the following warning to be emitted (on master):
>
> In kill-new:
> simple.el:5660:38: Warning: ‘ignore-error’ condition argument should
> not be quoted: 'quit
Sorry, here's the fix:
diff --git a/lisp/simple.el b/lisp/simple.el
index 54e71e1b040..6dc08ff0eb0 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -5657,7 +5657,7 @@ kill-new
;; interrupt this. If they interrupt it, we want to continue
;; so we become selection owner, so this doesn't stay slow.
(if (eq (window-system) 'x)
- (ignore-error 'quit (funcall
interprogram-paste-function))
+ (ignore-error quit (funcall interprogram-paste-function))
(funcall interprogram-paste-function)))))
(when interprogram-paste
(setq interprogram-paste
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, (continued)
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, sbaugh, 2023/07/12
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, Po Lu, 2023/07/12
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, Eli Zaretskii, 2023/07/13
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, sbaugh, 2023/07/13
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, Eli Zaretskii, 2023/07/13
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, sbaugh, 2023/07/13
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, Eli Zaretskii, 2023/07/15
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, Po Lu, 2023/07/15
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, Eli Zaretskii, 2023/07/15
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, Eli Zaretskii, 2023/07/15
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections,
sbaugh <=
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, Eli Zaretskii, 2023/07/15
- bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, Spencer Baugh, 2023/07/15
bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections, Mattias Engdegård, 2023/07/17