bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#64406: [PATCH] Improve commands to manage Python imports


From: Eli Zaretskii
Subject: bug#64406: [PATCH] Improve commands to manage Python imports
Date: Thu, 13 Jul 2023 09:07:34 +0300

> Cc: 64406@debbugs.gnu.org
> From: Matthias Meulien <orontee@gmail.com>
> Date: Sun, 09 Jul 2023 08:09:17 +0200
> 
> Here are two patches.
> 
> The first one revert part of the original patch where I introduced a
> useless detailed check of isort exit status itself.
> 
> The second one relates to your remarks: It shift the custom exit status
> of the Python script and make sure that an error is reported assoon as
> exit code >0.

Thanks.  Could you please make a single patch from these two?  There's
no need to revert the original one in a separate patch.

> Subject: [PATCH 1/2] Fix "Improve Python imports management commands"
> 
> * lisp/progmodes/python.el (python--do-isort): The isort library don't
> check for its version itself!

I don't think I understand this log entry.  What does it mean "the
isort library don't check its version"?
> +             ((eq 3 status) " (maybe isort version is less than 5.7.0?)")
                                                      ^^^^^^^
Here, "is older" should be more clear, I think.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]