[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64391: buffer narrowing slowdown regression in emacs 29
From: |
Stefan Monnier |
Subject: |
bug#64391: buffer narrowing slowdown regression in emacs 29 |
Date: |
Sun, 09 Jul 2023 14:52:52 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
> \(fn START END [:label LABEL] BODY)"
> (declare (indent 2) (debug t))
> - (if (eq (car rest) :label)
> + (if (and (eq (car rest) :label)
> + (symbolp (cadr rest)))
> `(internal--with-restriction ,start ,end (lambda () ,@(cddr rest))
> ,(cadr rest))
> `(internal--with-restriction ,start ,end (lambda () ,@rest))))
Doesn't look right: (cadr rest) should be an *expression* that evaluates
to a symbol, so in general it won't itself be a symbol.
>>> -When the optional argument @var{label}, a symbol, is present, the
>>> -narrowing is @dfn{labeled}. A labeled narrowing differs from a
>>> -non-labeled one in several ways:
>>> +When the optional argument @var{label}, which is evaluated to get the
>>> +label to use and must not be @code{nil},
>> What "must not be nil": the label or the result of its evaluation?
> The result of the evaluation of the label argument. I don't know how to
> make this clearer.
Maybe:
When the optional argument @var{label}, which should evaluate to
a non-nil value,
-- Stefan
- bug#64391: buffer narrowing slowdown regression in emacs 29, (continued)
- bug#64391: buffer narrowing slowdown regression in emacs 29, Eli Zaretskii, 2023/07/09
- bug#64391: buffer narrowing slowdown regression in emacs 29, Gregory Heytings, 2023/07/09
- bug#64391: buffer narrowing slowdown regression in emacs 29, Eli Zaretskii, 2023/07/09
- bug#64391: buffer narrowing slowdown regression in emacs 29, Gregory Heytings, 2023/07/09
- bug#64391: buffer narrowing slowdown regression in emacs 29, Eli Zaretskii, 2023/07/09
- bug#64391: buffer narrowing slowdown regression in emacs 29, Gregory Heytings, 2023/07/09
- bug#64391: buffer narrowing slowdown regression in emacs 29,
Stefan Monnier <=
- bug#64391: buffer narrowing slowdown regression in emacs 29, Gregory Heytings, 2023/07/09
- bug#64391: buffer narrowing slowdown regression in emacs 29, Stefan Monnier, 2023/07/09
- bug#64391: buffer narrowing slowdown regression in emacs 29, Gregory Heytings, 2023/07/09
- bug#64391: buffer narrowing slowdown regression in emacs 29, Eli Zaretskii, 2023/07/09
- bug#64391: buffer narrowing slowdown regression in emacs 29, Eli Zaretskii, 2023/07/09
- bug#64391: buffer narrowing slowdown regression in emacs 29, Gregory Heytings, 2023/07/09
- bug#64391: buffer narrowing slowdown regression in emacs 29, Eli Zaretskii, 2023/07/07
- bug#64391: buffer narrowing slowdown regression in emacs 29, Mattias EngdegÄrd, 2023/07/07
- bug#64391: buffer narrowing slowdown regression in emacs 29, Eli Zaretskii, 2023/07/07
- bug#64391: buffer narrowing slowdown regression in emacs 29, Mattias EngdegÄrd, 2023/07/07