[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color
From: |
Eli Zaretskii |
Subject: |
bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’ |
Date: |
Fri, 07 Jul 2023 21:15:39 +0300 |
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: michael_heerdegen@web.de, zack@owlfolio.org, 64232-done@debbugs.gnu.org
> Date: Fri, 07 Jul 2023 12:10:41 -0400
>
> >> > > --- a/lisp/emacs-lisp/bytecomp.el
> >> > > +++ b/lisp/emacs-lisp/bytecomp.el
> >> > > @@ -1128,7 +1128,8 @@ byte-compile-eval
> >> > > ;; we arguably should add it to
> >> > > b-c-noruntime-functions,
> >> > > ;; but it's not clear it's worth the trouble
> >> > > ;; trying to recognize that case.
> >> > > - (unless (get f 'function-history)
> >> > > + (unless (or (get f 'function-history)
> >> > > + (assq f
> >> > > byte-compile-function-environment))
> >> > > (push f
> >> > > byte-compile-noruntime-functions)))))))))))))
> >> >
> >> > Seems appropriate (and fixes this bug).
> >> > Actually with that patch the situation looks already quite ok'ish to me.
> >> Please install this on master, and thanks.
> > Ping! Any reasons this was not yet installed on master?
>
> Oops, sorry. Pushed,
Thanks.