[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64344: [PATCH] Make calculator work with customized mode-line
From: |
Eli Zaretskii |
Subject: |
bug#64344: [PATCH] Make calculator work with customized mode-line |
Date: |
Thu, 29 Jun 2023 12:38:36 +0300 |
> From: Andreas Schwab <schwab@suse.de>
> Cc: jm@pub.pink, 64344@debbugs.gnu.org
> Date: Thu, 29 Jun 2023 11:31:06 +0200
>
> On Jun 29 2023, Eli Zaretskii wrote:
>
> >> From: Andreas Schwab <schwab@suse.de>
> >> Cc: john muhl <jm@pub.pink>, 64344@debbugs.gnu.org
> >> Date: Thu, 29 Jun 2023 10:22:02 +0200
> >>
> >> On Jun 29 2023, Eli Zaretskii wrote:
> >>
> >> >> - (and bx (or (not lh) (> lh 0))))
> >> >> + (and bx (or (not lh) (> (if (listp lh) (cdr lh) lh)
> >> >> 0))))
> >> > ^^^^^
> >> > Shouldn't that be 'consp' instead? 'listp' returns non-nil for nil
> >> > argument.
> >>
> >> lh cannot be nil here, but it wouldn't make a difference anyway, since
> >> (cdr nil) returns nil.
> >
> > I prefer not to have, nor force others, to analyze code in order to
> > ensure it's correct.
>
> Then you need to add a comment, not change correct code.
There's no reason whatsoever to comment correct code.
bug#64344: [PATCH] Make calculator work with customized mode-line, Stephen Berman, 2023/06/29
bug#64344: [PATCH] Make calculator work with customized mode-line, john muhl, 2023/06/29