[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe
From: |
Randy Taylor |
Subject: |
bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe |
Date: |
Tue, 30 May 2023 00:14:29 +0000 |
On Monday, May 29th, 2023 at 10:54, Йордан Миладинов <yordanm@proton.me> wrote:
> Here's a patch that takes into account both your and Randy's remarks. It
> fixes both rust-ts-mode and go-ts-mode in a total of 15 lines.
Thanks! One tiny nit: In the commit message: * lisp/progmodes/go-ts-mode.el
(go-ts-mode) the (go-ts-mode) part should be (go-ts-mode--syntax-table). You
could also mention the bug # in the commit message somewhere, too - I
personally like to do it in the first line if it fits like so: Blah blah commit
message (Bug#63708)
Otherwise, looks good to me! Thanks for working on this.
>
> $ git diff --stat HEAD~ HEAD
> lisp/progmodes/go-ts-mode.el | 1 +
> lisp/progmodes/rust-ts-mode.el | 14 ++++++++++++--
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
> Cheers! YM
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, (continued)
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, Randy Taylor, 2023/05/29
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, Randy Taylor, 2023/05/28
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, Eli Zaretskii, 2023/05/29
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, Randy Taylor, 2023/05/29
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, Eli Zaretskii, 2023/05/29
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, Randy Taylor, 2023/05/29
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, Йордан Миладинов, 2023/05/29
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, Eli Zaretskii, 2023/05/29
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, Йордан Миладинов, 2023/05/29
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, Eli Zaretskii, 2023/05/29
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe,
Randy Taylor <=
- bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, Йордан Миладинов, 2023/05/30
bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe, Йордан Миладинов, 2023/05/30