bug#63690: 29.0.91; New vc commands missing on vc-menu

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Cc: 63690@debbugs.gnu.org
> Date: Wed, 24 May 2023 20:31:21 +0300
> 
> >> @@ -898,6 +927,15 @@ vc-menu-map
> >> +    (bindings--define-key map [vc-print-branch-log]
> >> +      '(menu-item "Show Branch History" vc-print-branch-log
> >> +            :help "Show the change log for branch root"))
> >
> > What is "branch root"?
> 
> Probably better to drop the word "root" to e.g.:
> 
>   "List the change log for branch"

This prompts for the branch to log, right?  Then the menu item should
ends in a "...", and the help text should be

   "List the change log for a branch"

> Then docstring of 'vc-print-branch-log' could be changed too.

Yes, and it should say that the command prompts for the branch to log.

> >> +    (bindings--define-key map [vc-switch-branch]
> >> +      '(menu-item "Switch Branch" vc-switch-branch
> >> +            :help "Switch to the branch"))
> >
> > "the" branch?
> 
> Maybe "the selected branch".

I think

  "Switch to another branch"

> Then it may need an ellipsis:
> "Switch Branch..."

Yes.

> > Also, AFAICT these commands are not described in the manual.  If they
> > are important enough to be on the menu bar, I think we should mention
> > them in the manual as well, no?
> 
> They are mentioned briefly in
> 
>   (info "(emacs) Creating Branches")
>   (info "(emacs) Switching Branches")
>   (info "(emacs) Editing VC Commands")

Mentioned, but not indexed.  Please always index every command
described in the manual, both its name and its key binding (if any).
This is necessary to allow users to find the description of each
command quickly and easily.

Also, vc-print-branch-log is not really described, it's just used in
an unrelated example of using a different feature.