[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63622: lisp/progmodes/python.el: performance regression introduced b
From: |
Stefan Monnier |
Subject: |
bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock |
Date: |
Mon, 22 May 2023 11:08:35 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
> @@ -869,18 +869,20 @@ python-font-lock-keywords
> Which one will be chosen depends on the value of
> `font-lock-maximum-decoration'.")
>
> -(defun python-font-lock-extend-region (beg end _old-len)
> - "Extend font-lock region given by BEG and END to statement boundaries."
> - (save-excursion
> - (save-match-data
> - (goto-char beg)
> - (python-nav-beginning-of-statement)
> - (setq beg (point))
> - (goto-char end)
> - (python-nav-end-of-statement)
> - (setq end (point))
> - (cons beg end))))
> -
> +(defvar font-lock-beg)
> +(defvar font-lock-end)
> +(defun python-font-lock-extend-region ()
> + "Extend font-lock region to statement boundaries."
> + (let ((beg font-lock-beg)
> + (end font-lock-end))
> + (goto-char beg)
> + (python-nav-beginning-of-statement)
> + (setq font-lock-beg (point))
> + (goto-char end)
> + (python-nav-end-of-statement)
> + (when (not (eobp)) (forward-char))
> + (setq font-lock-end (point))
> + (or (/= beg font-lock-beg) (/= end font-lock-end))))
>
> (defconst python-syntax-propertize-function
> (syntax-propertize-rules
Looks fine to me (I assume you've checked that it behaves about as well
as the previous code).
> @@ -6708,8 +6710,8 @@ python-mode
> nil nil nil nil
> (font-lock-syntactic-face-function
> . python-font-lock-syntactic-face-function)
> - (font-lock-extend-after-change-region-function
> - . python-font-lock-extend-region)))
> + (font-lock-extend-region-functions
> + . (python-font-lock-extend-region))))
> (setq-local syntax-propertize-function
> python-syntax-propertize-function)
> (setq-local imenu-create-index-function
This is bound to break in some cases. Please use `add-hook` instead.
Stefan
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, Tom Gillespie, 2023/05/20
- bug#63622: source of problem identified to be python-font-lock-extend-region, Tom Gillespie, 2023/05/21
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, Eli Zaretskii, 2023/05/21
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, Tom Gillespie, 2023/05/21
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, kobarity, 2023/05/21
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, Stefan Monnier, 2023/05/21
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, kobarity, 2023/05/22
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock,
Stefan Monnier <=
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, kobarity, 2023/05/23
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, Stefan Monnier, 2023/05/23
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, Tom Gillespie, 2023/05/23
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, kobarity, 2023/05/23
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, Tom Gillespie, 2023/05/24
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, Ruijie Yu, 2023/05/23
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, kobarity, 2023/05/24
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, Eli Zaretskii, 2023/05/26
- bug#63622: lisp/progmodes/python.el: performance regression introduced by multiline font-lock, kobarity, 2023/05/21