[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windo
From: |
Juri Linkov |
Subject: |
bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows |
Date: |
Fri, 19 May 2023 21:14:27 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
>> + (when (minibufferp) (select-window (get-mru-window)))
>
> Here and below I'd use
>
> (when (window-minibuffer-p)
>
> because it more clearly demonstrates the idea and also handles the
> (unlikely) case where a minibuffer is shown in a normal window.
Thanks, now pushed to emacs-29.
>> (window-state-put ws nil 'safe)))
>>
>> ;; Select the minibuffer when it was active before switching tabs
>> @@ -1575,8 +1575,7 @@ tab-bar-new-tab-to
>>
>> (when tab-bar-new-tab-choice
>> ;; Handle the case when it's called in the active minibuffer.
>> - (when (minibuffer-selected-window)
>> - (select-window (minibuffer-selected-window)))
>> + (when (minibufferp) (select-window (get-mru-window)))
>> (let ((ignore-window-parameters t)
>> (window--sides-inhibit-check t))
>> (if (eq tab-bar-new-tab-choice 'clone)
>
> You might want to try this with multiple frames (some of them without
> their own minibuffer window) jumping from one frame to another within
> the scope of 'read-from-minibuffer'.
I confirm that this works correctly.
- bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows, Juri Linkov, 2023/05/15
- bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows, Juri Linkov, 2023/05/16
- bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows, Juri Linkov, 2023/05/16
- bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows, martin rudalics, 2023/05/17
- bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows, Juri Linkov, 2023/05/17
- bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows, martin rudalics, 2023/05/18
- bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows, Juri Linkov, 2023/05/18
- bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows, martin rudalics, 2023/05/19
- bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows,
Juri Linkov <=
bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows, Eli Zaretskii, 2023/05/16