[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled
From: |
Tony Zorman |
Subject: |
bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled |
Date: |
Fri, 19 May 2023 17:16:20 +0200 |
On Thu, May 18 2023 19:54, Philip Kaludercic wrote:
> Steven Allen <steven@stebalien.com> writes:
>
>> * lisp/use-package/use-package-core.el (use-package-handler/:vc):
>> Return the new 'body'. Otherwise, the entire package declaration gets
>> dropped when byte-compiling.
>> ---
>> lisp/use-package/use-package-core.el | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/lisp/use-package/use-package-core.el
>> b/lisp/use-package/use-package-core.el
>> index 0d99e270a3f..e0e16134ed3 100644
>> --- a/lisp/use-package/use-package-core.el
>> +++ b/lisp/use-package/use-package-core.el
>> @@ -1619,7 +1619,8 @@ defvar use-package--form)
>> ;; See `use-package-handler/:ensure' for an explanation.
>> (if (bound-and-true-p byte-compile-current-file)
>> (funcall #'use-package-vc-install arg local-path) ; compile
>> time
>> - (push `(use-package-vc-install ',arg ,local-path) body)))) ; runtime
>> + (push `(use-package-vc-install ',arg ,local-path) body)) ; runtime
>> + body))
>>
>> (defun use-package-normalize--vc-arg (arg)
>> "Normalize possible arguments to the `:vc' keyword.
>
> CC'ing Tony, since he did most of the work here. Do you have any
> comments on this change?
Looks fine to me; @Steven thanks for catching this! Seems like I wasn't
careful enough when testing with a byte compiled file.
I'm not super familiar with the testing infrastructure here, but I
wonder whether there is an easy way to write a quick regression test for
this?
--
Tony Zorman | https://tony-zorman.com/
- bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled, Steven Allen, 2023/05/16
- bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled, Philip Kaludercic, 2023/05/18
- bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled,
Tony Zorman <=
- bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled, Philip Kaludercic, 2023/05/20
- bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled, Tony Zorman, 2023/05/21
- bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled, Steven Allen, 2023/05/26
- bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled, Eli Zaretskii, 2023/05/31
- bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled, Philip Kaludercic, 2023/05/31