bug#63539: 29.0.90; TRAMP fails to detect shell prompts containing ]

[Spencer Baugh]

Michael Albinus <michael.albinus@gmx.de> writes:
> Spencer Baugh <sbaugh@janestreet.com> writes:
>> But such machines' prompts stop working if they add color, which
>> shell-prompt-pattern also doesn't support (namely that regex doesn't
>> support escape sequences appearing after the prompt, which are necessary
>> to clear the coloring).
>>
>> So actually, how about setting shell-prompt-pattern to the following?
>> All it does is add support for escape characters after the prompt in
>> shell-prompt-pattern.  That would make my use case work.
>>
>> (setopt shell-prompt-pattern (rx (* (not (any "#$%>\n")))
>>       (any "#$%>")
>>       (* blank)
>>       ;; Escape characters.
>>       (* "^[[" (* (any ";" digit)) alpha (* blank))))
>
> Oh no! There are much more escape sequences but for coloring. We would
> open a can of worms if we start to handle them in Tramp regexps.

Wait, but we already have exactly this kind of regexp for escape
characters in tramp-shell-prompt-regexp.  That's where I copied
this regexp from.