[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties
From: |
Stefan Monnier |
Subject: |
bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations |
Date: |
Tue, 16 May 2023 10:04:15 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index a3dc1b0cfbf..b0c32b938a0 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -700,6 +700,7 @@ completion--twq-all
> ;; (concat (substring ustring 0 boundary)
> ;; completion))
> ;; t)
> + (add-text-properties 0 1 (text-properties-at 0
> completion) qcompletion)
> qcompletion))
> completions)
> qboundary))))
>
> It just re-adds text properties to completions produced by
> `completion-table-with-quoting', but I'm not sure it is the proper
> fix. What do you think?
For some properties, this may do The Wrong Thing :-(
E.g. it could copy some `display` properties to an unrelated part of
the text.
Stefan
- bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations, (continued)
- bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations, Daniel Mendler, 2023/05/17
- bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations, Eli Zaretskii, 2023/05/18
- bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations, Jim Porter, 2023/05/18
- bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations, Eli Zaretskii, 2023/05/18
- bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations, Daniel Mendler, 2023/05/18
- bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations, Stefan Monnier, 2023/05/18
- bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations, Jim Porter, 2023/05/18
- bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations, Daniel Mendler, 2023/05/18
- bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations, Stefan Monnier, 2023/05/18
- bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations, Jim Porter, 2023/05/23
bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations,
Stefan Monnier <=
bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations, Gregory Heytings, 2023/05/16