[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62116: RFE: eglot: support window.showDocument LSP RPC
From: |
João Távora |
Subject: |
bug#62116: RFE: eglot: support window.showDocument LSP RPC |
Date: |
Fri, 12 May 2023 01:54:07 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Felician Nemeth <felician.nemeth@gmail.com> writes:
> João Távora <joaotavora@gmail.com> writes:
>
>>> Since it advances the status quo, can this be merged? If not, how
>>> should we proceed?
>>
>> Haven't looked at it, but I'd say yes. However, Alan Donovan
>> has replied recently, with a recipe showcasing his particular
>> use case. I dont' have time to try it right now, but if you
>> could try his recipe/use case with your solution, it would be
>> great.
>
> It requires to patch and recompile gopls, which would be too much effort
> for me, unfortunately.
I've now followed Alan's recipe and played around a bit with this.
Starting from your version, I came up with this simpler patch.
I was about to push it, but let's hear your opinions first (though we
can always push and tweak it later).
João
>From 1acbbc188a7c43063f9d6a4d25e3d854052cc956 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Felici=C3=A1n=20N=C3=A9meth?= <felician.nemeth@gmail.com>
Date: Fri, 12 May 2023 01:50:05 +0100
Subject: [PATCH] Eglot: support window/showRequest (bug#62116)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Co-authored-by: João Távora <joaotavora@gmail.com>
* lisp/progmodes/eglot.el (eglot-client-capabilities): Advertise
window/showDocument.
(eglot-handle-request window/showDocument): New handler.
---
lisp/progmodes/eglot.el | 24 +++++++++++++++++++++++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 66d893a14b5..291ae9b83d9 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -845,7 +845,8 @@ eglot-client-capabilities
`(:valueSet
[,@(mapcar
#'car eglot--tag-faces)])))
- :window `(:workDoneProgress t)
+ :window `(:showDocument (:support t)
+ :workDoneProgress t)
:general (list :positionEncodings ["utf-32" "utf-8" "utf-16"])
:experimental eglot--{})))
@@ -2366,6 +2367,27 @@ eglot-handle-request
"Handle server request workspace/workspaceFolders."
(eglot-workspace-folders server))
+(cl-defmethod eglot-handle-request
+ (_server (_method (eql window/showDocument)) &key
+ uri external takeFocus selection)
+ "Handle request window/showDocument."
+ (if (eq external t) (browse-url uri)
+ (let* (;; requests run with a let-bound `eglot--cached-server',
+ ;; but when finding files from handlers, this fools
+ ;; `eglot--maybe-activate-editing-mode'.
+ (eglot--cached-server nil))
+ (with-current-buffer (find-file-noselect (eglot--uri-to-path uri))
+ (cond (takeFocus
+ (pop-to-buffer (current-buffer))
+ (select-frame-set-input-focus (selected-frame)))
+ ((display-buffer (current-buffer))))
+ (when selection
+ (eglot--widening
+ (pcase-let ((`(,beg . ,end) (eglot--range-region selection)))
+ (goto-char beg)
+ (pulse-momentary-highlight-region beg end 'highlight)))))))
+ '(:success t))
+
(defun eglot--TextDocumentIdentifier ()
"Compute TextDocumentIdentifier object for current buffer."
`(:uri ,(eglot--path-to-uri (or buffer-file-name
--
2.39.2
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, (continued)
bug#62116: RFE: eglot: support window.showDocument LSP RPC, Felician Nemeth, 2023/05/06
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, Felician Nemeth, 2023/05/08
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/08
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, Felician Nemeth, 2023/05/09
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, Alan Donovan, 2023/05/09
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/11
bug#62116: RFE: eglot: support window.showDocument LSP RPC,
João Távora <=
bug#62116: RFE: eglot: support window.showDocument LSP RPC, Alan Donovan, 2023/05/12
bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/15
bug#62116: RFE: eglot: support window.showDocument LSP RPC, Felician Nemeth, 2023/05/13
bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/13
bug#62116: RFE: eglot: support window.showDocument LSP RPC, Felician Nemeth, 2023/05/14
bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/14
bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/15
bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/16
bug#62116: RFE: eglot: support window.showDocument LSP RPC, Alan Donovan, 2023/05/24
bug#62116: RFE: eglot: support window.showDocument LSP RPC, Dmitry Gutov, 2023/05/24