[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63338: 29.0.90; package-vc-install'ing the same package multiple tim
From: |
Philip Kaludercic |
Subject: |
bug#63338: 29.0.90; package-vc-install'ing the same package multiple times results in duplication in package-selected-packages |
Date: |
Mon, 08 May 2023 10:36:55 +0000 |
Jimmy Yuen Ho Wong <wyuenho@gmail.com> writes:
> Reproduction:
>
> 0. (setq custom-file (const user-emacs-directory "custom.el"))
> 1. M-x package-vc-install company
> 2. M-x package-vc-install company RET y
> 3. C-x C-f ~/.emacs/custom.el
> 4. Observe that `company` has been listed twice under
> `package-selected-packages`.
>
> Expectation:
>
> Installing the same package twice should not result in its duplication
> in `package-selected-packages`.
An easy fix would be just to ensure that package-selected-packages is
always deduplicated before assigning the value:
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index bbe2b8bb4af..988b92da75b 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1992,7 +1992,7 @@ package--find-non-dependencies
(defun package--save-selected-packages (&optional value)
"Set and save `package-selected-packages' to VALUE."
(when value
- (setq package-selected-packages value))
+ (setq package-selected-packages (delete-dups value)))
(if after-init-time
(customize-save-variable 'package-selected-packages
package-selected-packages)
(add-hook 'after-init-hook #'package--save-selected-packages)))
- bug#63338: 29.0.90; package-vc-install'ing the same package multiple times results in duplication in package-selected-packages, Jimmy Yuen Ho Wong, 2023/05/06
- bug#63338: 29.0.90; package-vc-install'ing the same package multiple times results in duplication in package-selected-packages,
Philip Kaludercic <=
- bug#63338: 29.0.90; package-vc-install'ing the same package multiple times results in duplication in package-selected-packages, Eli Zaretskii, 2023/05/08
- bug#63338: 29.0.90; package-vc-install'ing the same package multiple times results in duplication in package-selected-packages, Jimmy Wong, 2023/05/08
- bug#63338: 29.0.90; package-vc-install'ing the same package multiple times results in duplication in package-selected-packages, Philip Kaludercic, 2023/05/10
- bug#63338: 29.0.90; package-vc-install'ing the same package multiple times results in duplication in package-selected-packages, Philip Kaludercic, 2023/05/13
- bug#63338: 29.0.90; package-vc-install'ing the same package multiple times results in duplication in package-selected-packages, Jimmy Wong, 2023/05/14
- bug#63338: 29.0.90; package-vc-install'ing the same package multiple times results in duplication in package-selected-packages, Philip Kaludercic, 2023/05/16