bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked


From: Gregory Heytings
Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing.
Date: Thu, 04 May 2023 15:45:29 +0000


Eli, I've been away for a month, and apparently I forgot to push the merge. Sorry for that. Is this still okay now?

You've got to be kidding! I was thinking about releasing Emacs 29.1 soon!


Sorry again.


Please show the full diffs of the proposed merge, I will have to think about this again, and think hard.


You can get them by checking out the scratch/long-lines-cleanup and doing "git diff emacs-29..." Just in case, I attach the full diff. Most of it are renamings and documentation improvements. The main code change is the function 'get_nearby_bol_pos' used by 'get_small_narrowing_begv'.

By the way, I think we should add a hook and run it when long line optimizations are activated, so that users can, for example, automatically turn modes that are known to be problematic off. WDYT?

I don't think we should add hooks without real-life use cases that we understand and consider important. Hooks called by redisplay are especially problematic, and should be added very sparingly.


Okay.

Attachment: long-lines-cleanup.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]