[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63141: Incorrect indentation in csharp-mode
From: |
Theodor Thornhill |
Subject: |
bug#63141: Incorrect indentation in csharp-mode |
Date: |
Sat, 29 Apr 2023 12:40:30 +0200 |
On 29 April 2023 08:16:38 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Jen-Chieh Shen <jcs090218@gmail.com>
>> Date: Fri, 28 Apr 2023 22:54:15 -0700
>> Cc: theo@thornhill.no, 63141@debbugs.gnu.org, jostein@kjonigsen.net
>>
>> > Isn't this user preference that is customizable via c-offset-alist?
>>
>> Yes, it is.
>
>Then this is not a bug.
>
>> csharp-mode has the following:
>>
>> ```elisp
>> (c-add-style "csharp"
>> '("java"
>> (c-basic-offset . 4)
>> (c-comment-only-line-offset . (0 . 0))
>> (c-offsets-alist . ((inline-open . 0)
>> (arglist-intro . +)
>> (arglist-close . 0)
>> (inexpr-class . 0)
>> (case-label . +)
>> (cpp-macro .
>> c-lineup-dont-change)
>> (substatement-open . 0)))))
>> ```
>>
>> I consider it an awkward indentation, so better to change the default
>> (change to the expected
>> behavior).
>
>I'll let Theo and Jostein chime in regarding the accepted practices in
>C#, but in general it is not enough to hear from one or several users
>that they don't like the defaults in order for us to change the
>default behavior. These customization options exist precisely so that
>people who don't like the defaults could easily adjust Emacs to their
>liking. Why would you impose your personal preferences on everyone
>else, instead of letting them customize this as they see fit?
I agree. It's not a bug, but could absolutely be a missing
feature/consideration. I'd be happy to review a patch with the proposed
changes, though.
Thanks,
Theo
- bug#63141: Incorrect indentation in csharp-mode, (continued)
- bug#63141: Incorrect indentation in csharp-mode, Eli Zaretskii, 2023/04/28
- bug#63141: Incorrect indentation in csharp-mode, Theodor Thornhill, 2023/04/28
- bug#63141: Incorrect indentation in csharp-mode, Theodor Thornhill, 2023/04/28
- bug#63141: Incorrect indentation in csharp-mode, Eli Zaretskii, 2023/04/28
- bug#63141: Incorrect indentation in csharp-mode, Theodor Thornhill, 2023/04/28
- bug#63141: Incorrect indentation in csharp-mode, Theodor Thornhill, 2023/04/28
- bug#63141: Incorrect indentation in csharp-mode, Jen-Chieh Shen, 2023/04/28
- bug#63141: Incorrect indentation in csharp-mode, Eli Zaretskii, 2023/04/29
- bug#63141: Incorrect indentation in csharp-mode, Jen-Chieh Shen, 2023/04/29
- bug#63141: Incorrect indentation in csharp-mode, Eli Zaretskii, 2023/04/29
- bug#63141: Incorrect indentation in csharp-mode,
Theodor Thornhill <=
- bug#63141: Incorrect indentation in csharp-mode, Eli Zaretskii, 2023/04/29
- bug#63141: Incorrect indentation in csharp-mode, Jen-Chieh Shen, 2023/04/29
- bug#63141: Incorrect indentation in csharp-mode, Theodor Thornhill, 2023/04/29
- bug#63141: Incorrect indentation in csharp-mode, Jen-Chieh Shen, 2023/04/29
- bug#63141: Incorrect indentation in csharp-mode, Theodor Thornhill, 2023/04/29