[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62761: ruby-add-log-current-method drops some segments when singleto
From: |
Dmitry Gutov |
Subject: |
bug#62761: ruby-add-log-current-method drops some segments when singleton definition references outer module |
Date: |
Tue, 11 Apr 2023 00:02:03 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 |
Example:
module M
module N
module C
class D
def C.foo
_
end
end
end
end
end
(ruby-add-log-current-method) currently returns "M::C.foo"
While it should return "M::N::C.foo". Patch attached.
This discovery stems from Mattias EngdegÄrd's report (in private) about
an ignored return value from `nreverse`.
Is this good for emacs-29?
It seems pretty safe (with decent test coverage, including the new
test), but probably low urgency. Not a regression either.
ruby-add-log-reference-containing.diff
Description: Text Data
- bug#62761: ruby-add-log-current-method drops some segments when singleton definition references outer module,
Dmitry Gutov <=