[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode
From: |
Yuan Fu |
Subject: |
bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode |
Date: |
Sun, 2 Apr 2023 15:10:55 -0700 |
> On Mar 30, 2023, at 7:31 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Thu, 30 Mar 2023 01:11:48 -0700
>> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
>> 62429-done@debbugs.gnu.org,
>> theodor thornhill <theo@thornhill.no>
>>
>>>>> OK, but then how will these JSX-specific faces fit into the overall
>>>>> scheme of treesit-font-lock faces? For example, in what level will
>>>>> they be used, and how will users know what level to set to see these
>>>>> faces in their buffers?
>>>>
>>>> At level 3 for tsx-ts-mode, under the “jsx” feature. So they are enabled
>>>> by default. Though it’s true that it’s not immediately obvious what face
>>>> to customize. At the very least these faces appear in the customize group
>>>> of typescript. We can add something to the docstring of the major mode,
>>>> too.
>>>>
>>>>>
>>>>> These are the downsides of mode-specific faces, and if we think it's
>>>>> important enough to have them, we should resolve these issues when we
>>>>> install such faces.
>>>
>>> Then it is fine by me, as long as those measures you mentioned are
>>> taken to make sure users know how to customize font-lock with these
>>> faces.
>>
>> Cool. I pushed the change.
>
> Thanks, but please also tell in the doc string of the mode which
> font-lock level uses these special faces.
Done.
Yuan
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode,
Yuan Fu <=