[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62009: 29.0.60; Emacs crashes on setf symbol-name
From: |
Eli Zaretskii |
Subject: |
bug#62009: 29.0.60; Emacs crashes on setf symbol-name |
Date: |
Fri, 10 Mar 2023 13:59:28 +0200 |
> Date: Fri, 10 Mar 2023 10:59:03 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: Eli Zaretskii <eliz@gnu.org>, Philip Kaludercic <philipk@posteo.net>,
> michael_heerdegen@web.de, monnier@iro.umontreal.ca,
> 62009@debbugs.gnu.org,
> Augusto Stoffel <arstoffel@gmail.com>
>
> > Creating a string is not a good idea since it will lead to an
> > unacceptably large performance overhead.
>
> Is "symbol-name" a function that is used in performance-critical code?
Yes, it is. Just grep for it. We even call it from C quite a few
times. And processing is just one aspect of that; memory and GC is
another, not less important.
> And did you actually measure that performance overhead before concluding
> that it it "unacceptably large"?
Anything greater than zero is unacceptably large from where I stand,
when the other side of the balance is the use case against which this
protects.
> > Raising an exception upon modification would be the best approach.
>
> That would also come with a performance overhead, as there is currently no
> way to distinguist strings that are used for symbol names from other
> strings. Not to mention the added complexity in the code.
Which is why we should do neither.
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name, (continued)
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name, Po Lu, 2023/03/11
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name, Robert Pluim, 2023/03/13
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name, Po Lu, 2023/03/13
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name, Eli Zaretskii, 2023/03/13
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name, Po Lu, 2023/03/13
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name, Eli Zaretskii, 2023/03/13
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name,
Eli Zaretskii <=
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name, Eli Zaretskii, 2023/03/10
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name, Gregory Heytings, 2023/03/10
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name, Po Lu, 2023/03/11
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name, Eli Zaretskii, 2023/03/11
- bug#62009: 29.0.60; Emacs crashes on setf symbol-name, Philip Kaludercic, 2023/03/10