[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61913: java-ts-mode query error for string highlight, due to recent
From: |
Vincenzo Pupillo |
Subject: |
bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java. |
Date: |
Thu, 02 Mar 2023 17:18:32 +0100 |
Yes, indeed "text_block" are not recognized by earlier versions of
tree-sitter-java.
I have prepared a new patch that checks if "text_block" are recognized and
adjusts the query accordingly.
Also java-mode seems not to recognize "text_block".
You can check the result in the attached images.
Thank you.
Vincenzo
In data gioved� 2 marzo 2023 14:01:56 CET, Eli Zaretskii ha scritto:
> > From: Vincenzo Pupillo <v.pupillo@gmail.com>
> > Date: Thu, 02 Mar 2023 13:21:05 +0100
> >
> > a recent commit in tree-sitter-java
> > (https://github.com/tree-sitter/tree-sitter-java/commit/2b3b776b953a34ccffb647dd89732db79690d4c5)
> >
> > removed "text_block" from grammar.js. This causes a bug in java-ts-mode
> > when treesit-fon-lock-level is > 1
> >
> > Error during redeployment: (jit-lock-function 8295) reported
> > (treesit-query-error "Node type error at" 42 "(string_literal)
> > @font-lock-string-face (text_block) @font-lock-string-face" "Debugging the
> > query with `treesit-query-validate'")
> >
> >
> > The attached patch fixes the problem.
>
> Wouldn't removing text_block from our code cause problems if someone
> uses tree-sitter-java from before the removal?
>
> Is there a way to write code which handles text_block if it exists?
>
java_ts_mode_string_highlight.patch
Description: Text Data
java_text_block_new_ts_grammar.png
Description: PNG image
java_text_block_regula_java_mode.png
Description: PNG image
java_text_block_previous_ts_grammar.png
Description: PNG image
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java., Vincenzo Pupillo, 2023/03/02
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java., Eli Zaretskii, 2023/03/02
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java.,
Vincenzo Pupillo <=
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java., Vincenzo Pupillo, 2023/03/02
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java., Yuan Fu, 2023/03/03
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java., Eli Zaretskii, 2023/03/04
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java., Yuan Fu, 2023/03/04
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java., Vincenzo Pupillo, 2023/03/05
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java., Eli Zaretskii, 2023/03/05
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java., Theodor Thornhill, 2023/03/06
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java., Vincenzo Pupillo, 2023/03/06
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java., Eli Zaretskii, 2023/03/09
- bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java., Vincenzo Pupillo, 2023/03/09