bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#58921: Tab completion hangs in eshell


From: Stefan Monnier
Subject: bug#58921: Tab completion hangs in eshell
Date: Thu, 23 Feb 2023 13:08:36 -0500
User-agent: Gnus/5.13 (Gnus v5.13)

> @@ -304,36 +296,26 @@ pcomplete/tar
>         ((pcomplete-match "\\`--info-script=\\(.*\\)" 0)
>          (pcomplete-here* (pcomplete-entries)
>                           (pcomplete-match-string 1 0)))
> -       ((pcomplete-match "\\`--label=" 0)
> -        (pcomplete-here*))
> -       ((pcomplete-match "\\`--mode=" 0)
> -        (pcomplete-here*))
>         ((pcomplete-match "\\`--new-volume-script=\\(.*\\)" 0)
>          (pcomplete-here* (pcomplete-entries)
>                           (pcomplete-match-string 1 0)))
> -       ((pcomplete-match "\\`--newer=" 0)
> -        (pcomplete-here*))
>         ((pcomplete-match "\\`--owner=\\(.*\\)" 0)
>          (pcomplete-here* (pcmpl-unix-user-names)
>                           (pcomplete-match-string 1 0)))
> -       ((pcomplete-match "\\`--record-size=" 0)
> -        (pcomplete-here*))
>         ((pcomplete-match "\\`--rsh-command=\\(.*\\)" 0)
>          (pcomplete-here* (funcall pcomplete-command-completion-function)
>                           (pcomplete-match-string 1 0)))
>         ((pcomplete-match "\\`--starting-file=\\(.*\\)" 0)
>          (pcomplete-here* (pcomplete-entries)
>                           (pcomplete-match-string 1 0)))
> -       ((pcomplete-match "\\`--suffix=" 0)
> -        (pcomplete-here*))
> -       ((pcomplete-match "\\`--tape-length=" 0)
> -        (pcomplete-here*))
>         ((pcomplete-match "\\`--use-compress-program=\\(.*\\)" 0)
>          (pcomplete-here* (funcall pcomplete-command-completion-function)
>                           (pcomplete-match-string 1 0)))
>         ((pcomplete-match "\\`--volno-file=\\(.*\\)" 0)
>          (pcomplete-here* (pcomplete-entries)
> -                         (pcomplete-match-string 1 0)))))
> +                         (pcomplete-match-string 1 0)))
> +       ((pcomplete-match "\\`--.*=" 0)
> +        (pcomplete-here*))))
>      (unless saw-option
>        (pcomplete-here
>         (mapcar #'char-to-string

This looks good, but doesn't that still leave an inf-loop bug when the
input doesn't (pcomplete-match "\\`--.*=" 0)?


        Stefan






reply via email to

[Prev in Thread] Current Thread [Next in Thread]