bug#61652: 28.2; Read-only mode and View mode

[Eli Zaretskii]

> From: Bernd Rellermeyer <bernd.rellermeyer@t-online.de>
> Date: Mon, 20 Feb 2023 09:41:33 +0100
> 
> 
> I have the following scenario:
> 
> 1. View a buffer in View mode.
> 2. Turn off Read-Only mode, e.g. by pressing `C-x C-q`.
> 3. Turn on Read-Only mode and View mode again, eg. by pressing `C-x
> C-q`-
> 4. Exit View mode by `View-exit`, e.g. by pressing `e`.
> 
> Now the buffer is in Read-Only mode. In my opinion it should be
> writable. The reason is the variable `view-old-buffer-read-only`, which
> is set on entering View mode (`view--enable`) to the (old) value of
> `buffer-read-only`. But in my scenario, the value of `buffer-read-only`
> is already the new one, as set in `read-only-mode`.

If the buffer is already read-only when you enter View mode, why
should we reset read-only when exiting View mode?  We are trying to
leave the buffer as we found it, which in this case is read-only.

Or what am I missing?