bug#61631: 29.0.60; The indentation of switch case is broken on typescript-ts-mode and tsx-ts-mode

[Theodor Thornhill]

Eason Huang <aqua0210@foxmail.com> writes:

> Theodor Thornhill <theo@thornhill.no> writes:
>
>> Eason Huang <aqua0210@foxmail.com> writes:
>>
>>> Theodor Thornhill <theo@thornhill.no> writes:
>>>
>>>> On 19 February 2023 14:24:30 CET, Eason Huang <aqua0210@foxmail.com> wrote:
>>>>>Hello Theodor and Emacs dev team,
>>>>>
>>>>>Recently I found that the indentation is broken in typescript-ts-mode
>>>>>and tsx-ts-mode. When I press RET (M-x newline) after the ':' in the
>>>>>case clause, it will always indent to the the same position of previouse 
>>>>>line.
>>>>>
>>>>>For example:
>>>>>In typescript-ts-mode and tsx-ts-mode will get this result as below:
>>>>>
>>>>>```
>>>>>let day: number = 1;
>>>>>
>>>>>switch (day) {
>>>>>case 0:
>>>>>console.log("It is a Sunday.");
>>>>>break;
>>>>>case 1:
>>>>>console.log("It is a Monday.");
>>>>>break;
>>>>>default:
>>>>>console.log("No such day exists!");
>>>>>break;
>>>>>}
>>>>>```
>>>>>expected:
>>>>>
>>>>>```
>>>>>let day: number = 1;
>>>>>
>>>>>switch (day) {
>>>>>case 0:
>>>>>  console.log("It is a Sunday.");
>>>>>  break;
>>>>>case 1:
>>>>>  console.log("It is a Monday.");
>>>>>  break;
>>>>>default:
>>>>>  console.log("No such day exists!");
>>>>>break;
>>>>>}
>>>>>```
>>>>>
>>>>>steps to reprodue:
>>>>>
>>>>>1. start emacs with `emacs -Q`
>>>>>2. C-x C-f ~/test.tsx to open a test.tsx
>>>>>3. M-x typescript-ts-mode
>>>>>4. input the exmaple code mentioned above
>>>>>5. you will see the result.
>>>>>
>>>>>--
>>>>
>>>>
>>>> Great, thanks! I'll fix it tonight, unless you want to devise a patch 
>>>> yourself?
>>>>
>>> Hi Theo,
>>>
>>> Sorry, I have no idear how to fix it.
>>>
>>> I tried the latest commit(fc4bfa76db9) of emacs-29 branch, but the issue is 
>>> still existed.
>>>
>>> --
>>> Eason Huang
>>
>> No problem, pushing it now.
>>
>
> Great, thanks!
>
> I just build commit 19480aa30e3, and the issue has been fixed now.
>
> -- 
> Eason Huang

Good news!

theo