[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-funct
From: |
Theodor Thornhill |
Subject: |
bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function |
Date: |
Sat, 18 Feb 2023 23:20:00 +0100 |
Ping :-)
>>
>> FWIW I don't see this as a good enough reason in itself. If there is
>> little to no discernible benefit, supporting esoteric features can
>> become code bloat that makes maintenance of more important features
>> difficult. There is a fair amount of junk in the LSP standard, or
>> simply stuff that doesn't make as much sense in Emacs as it does in
>> other editors.
>>
>
> Yeah, I agree. However, this should make sense in Emacs too, no?
>
>> Regardless, I'm not opposed to this feature if there's a simple enough
>> patch. But we should weigh pros and cons -- and Felicián's request to
>> measure the pros is quite reasonable.
>
> The patch is simple enough, it could just be its own function, to be
> executed. Then it's a one-liner in the exit-function
>
>>
>> (Not to mention that a smart enough server can already derive these
>> smarts from the evolution of the LSP document's contents as reported by
>> the client.)
>>
>
> Maybe - I don't think that's reason enough to dismiss the command
> argument outright, though.
>
>> João
>
> Theo