|
From: | Gregory Heytings |
Subject: | bug#61504: 29.0.60; executing byte-code from previous build causes SIGSEGV crash |
Date: | Tue, 14 Feb 2023 17:00:55 +0000 |
Thanks for the review!
The patch is all right, I suppose, but it would be nice to do without the extra cons. Maybe a new specpdl case is warranted? `save-excursion` has one.
That's a possible improvement, but I think it's not safe enough for Emacs 29.
By the way, doesn't the patch switch the restoration order of narrowing and restriction, respectively? Maybe it doesn't matter?
Hmmm, that's a good question! The evaluation order of parameters is unspecified in C, so actually the order could be switched or not, depending on what the compiler chooses to do. That being said, AFAICS it doesn't matter in this case, indeed.
[Prev in Thread] | Current Thread | [Next in Thread] |